Save profile immediately upon death #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of this, but as a server side option. |
|
@Lacyway I actually agree, so I've went ahead and changed it! Hope this implementation is good |
Awesome, I'll let Sparta take a look on the server side, then I'll go through the code and merge when it's ready on the server. |
Lacyway
reviewed
May 22, 2024
|
Also @ArchangelWTF can you DM me on Discord, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some part of an initial anti alt-f4 implementation, I think it can get more fleshed out once reconnecting is added as there's no way to currently tell if a disconnection is on purpose or if the client just dropped out due to a bad internet or a game crash.
Eventually, maybe letting the host handle saving the profiles of clients might also be a good alternative.. But I'm not sure as to how feasible that is in the current system.